From bcec922e3e9579d7f58f2c19fc82eb238f87a34c Mon Sep 17 00:00:00 2001 From: Jonas Date: Wed, 17 Jul 2024 19:29:56 -0400 Subject: [PATCH] fs: remove unnecessary option argument validation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/53861 Reviewed-By: Yagiz Nizipli Reviewed-By: James M Snell Reviewed-By: Vinícius Lourenço Claro Cardoso --- lib/fs.js | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/lib/fs.js b/lib/fs.js index 1d7bd55ca7a72e..65889ee97ea727 100644 --- a/lib/fs.js +++ b/lib/fs.js @@ -1350,19 +1350,20 @@ function mkdirSync(path, options) { let mode = 0o777; let recursive = false; if (typeof options === 'number' || typeof options === 'string') { - mode = options; + mode = parseFileMode(options, 'mode'); } else if (options) { - if (options.recursive !== undefined) + if (options.recursive !== undefined) { recursive = options.recursive; - if (options.mode !== undefined) - mode = options.mode; + validateBoolean(recursive, 'options.recursive'); + } + if (options.mode !== undefined) { + mode = parseFileMode(options.mode, 'options.mode'); + } } - path = getValidatedPath(path); - validateBoolean(recursive, 'options.recursive'); const result = binding.mkdir( - path, - parseFileMode(mode, 'mode'), + getValidatedPath(path), + mode, recursive, );