Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dither toggle controls create large gaps in minimally-styled "reader" views #6

Open
jpco opened this issue Sep 29, 2024 · 0 comments
Open

Comments

@jpco
Copy link

jpco commented Sep 29, 2024

I first noticed this using https://github.com/j6k4m8/goosepaper to render pages from the RSS feed down to a PDF, but it's reproducible with Firefox's reader mode:

20240928_19h48m20s_grim

This seems to happens in views with minimal styling due to the .dither-toggle SVGs being defaulted to a width of 100% (though their content is shrunk down to zero pixels tall). For reasons I'm not clear on, those SVGs are interpreted as being "content" while the other SVGs aren't, but perhaps there's some invocation that can tell these interpreters otherwise.

Alternatively, a more brute-force fix could be to simply not include these dither-toggle controls at all in the HTML and only inject them with javascript on page load. This makes some sense given the controls don't actually do anything if the browser can't interpret javascript anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant