Skip to content

Commit

Permalink
[signing] Correct an error in signature attachment
Browse files Browse the repository at this point in the history
1. Use `dict.get` instead of `getattr`.

Signed-off-by: Chris Frantz <[email protected]>
  • Loading branch information
cfrantz committed May 7, 2024
1 parent a4d179a commit ecd6e47
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions rules/signing.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -591,8 +591,8 @@ def _offline_signature_attach(ctx):
ctx,
tc.tools.opentitantool,
inputs[f]["bin"],
getattr(inputs[f], "ecdsa_sig", None),
getattr(inputs[f], "rsa_sig", None),
inputs[f].get("ecdsa_sig"),
inputs[f].get("rsa_sig"),
inputs[f].get("spx_sig"),
)
outputs.append(out)
Expand Down

0 comments on commit ecd6e47

Please sign in to comment.