Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N-API support #6

Closed
NickNaso opened this issue Mar 31, 2018 · 5 comments
Closed

N-API support #6

NickNaso opened this issue Mar 31, 2018 · 5 comments

Comments

@NickNaso
Copy link
Contributor

NickNaso commented Mar 31, 2018

Hi @lovell ,
I worked on this native addon and I ported it to N-API
You can find my work here: https://github.com/NickNaso/highwayhash/tree/napi
If you want experiment with N-API you can create a branch and call it "napi" so I can execute the PR on it.
After that we can iterate to over it and at the end publish a tagged version of highwayhash like reported here: https://nodejs.org/en/docs/guides/publishing-napi-modules/

@lovell
Copy link
Owner

lovell commented Apr 3, 2018

Hello again, thanks for this Nick, like with your similar improvements for farmhash at lovell/farmhash#19 we can merge this when prebuild supports N-API too.

@lovell
Copy link
Owner

lovell commented Jul 3, 2020

Hi @NickNaso, I'd be happy to accept and merge a PR for this if it's something you're still interested in.

@NickNaso
Copy link
Contributor Author

NickNaso commented Jul 4, 2020

Hi @lovell it could be great, but before to make a PR I want update and review my work. I will try to do tomorrow.

@lovell
Copy link
Owner

lovell commented Jul 4, 2020

Brilliant, thank you, there's no time pressure.

@NickNaso NickNaso mentioned this issue Jul 6, 2020
@lovell
Copy link
Owner

lovell commented Jul 8, 2020

v3.0.0 now available, thanks again for the PR.

@lovell lovell closed this as completed Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants