Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] crossfade #13

Open
lovegaoshi opened this issue Sep 5, 2023 · 2 comments
Open

[feat] crossfade #13

lovegaoshi opened this issue Sep 5, 2023 · 2 comments

Comments

@lovegaoshi
Copy link
Owner

  1. make 2 exoplayers that switch
  2. whenever exoplayers switch, recreate notificationManager
  3. make a button to simply switch exoplayer. this should be seamless because exoplayers should not be stopped.
  4. if notificationMnager is not flickering and not stopping playback, on switch set the other exoplayer to "the next song" and add in fade in/out, acutally for now just stop volume is fine
  5. hope nothing crushes
@lovegaoshi
Copy link
Owner Author

this abomination actually meets 3 i dont think it flickers, onward to implement 4

@lovegaoshi
Copy link
Owner Author

to make this actually useable in APM (which handles queue outside of RNTP) I would rather make crossfade switch manually instaed of automatically. its also partly i dont know how to add listeners in kotlin. manually doing this also means if not handled then RNTP will behave exactly as crossfade is not implemented, just plus the exoplayer2 initialization cost.

The two exoplayers inside kotlinaudio will have the exact same queue. its up to me to specify what should be played.

the first KA commit is still necessary because there can only be one exoplayer "in focus" thus the whole currentPlayer() setup is needed.

this feels like a giant mess but hopefully by keeping both exoplayers ahving the same queue, QueuedAudioPlayer will still function normally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant