-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.11.0 Update #54
Comments
@hahawoo Any idea how we could add this: ? |
The time has come! The wiki is not yet up to date, but by updating love-api we can help with that effort too. I'll be trying to get a few PRs in into that new branch |
Unfortunately, PixelFormats are both an Enum and a returned tables of the format of key-boolean pairs. So you need to represent them in two formats The best way would be to have the format defined once in the local PixelFormats = {
type = "table",
name = "formats",
description = "A table containing PixelFormats as keys, and a boolean indicating whether the format is supported as values. Not all systems support all formats.",
table = {
{ type = "boolean", name = "rgba8" },
...
}
} And use it in both returns = { PixelFormats } Then there would be a separate Does this make sense? I can't think of a better alternative NOTE: It could be the other way around too, which probably would make sense too |
Are there any wiki pages which use the PixelFormats directly? After a quick search I only found it in
My question was aiming at the problem, that the enum page itself has multiple sections and a data table for the description of the constants. |
The functions that return it as a table are:
The function that return it as an enum are:
The functions that take it as an enum parameter are:
PS: When the wiki says it returns CanvasFormats and CompressedImageFormat, it should be fixed and use PixelFormat instead since the idea of PixelFormat is to unify all this different enums |
So the table is split in three: One cannot make assumptions about what And even though the table is split like I detailed above, it would be best to just unify them for all the cases instead of having it split |
Cant wait for this |
I've updated it to 11.2 (via wiki scraping, see #84). The PixelFormat information still isn't there though. |
@hahawoo If you want to, we can close this issue. |
I'd argue that this should be closed and a new one should be opened with what's currently missing I'll probably open one for the JUST RELEASED 11.3 version, since there are already wiki entries for some of it and the changelog was recently updated in the main repo. |
@rm-code @pablomayobre Sounds good! |
Started a branch at https://github.com/love2d-community/love-api/tree/update_to_love0110
TODO:
The text was updated successfully, but these errors were encountered: