Allow configuring when links should be enabled #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Links can now be configured with whether they should be enabled before, during or after the item. Sometimes streaming links aren't a link to the specific item, but to a stream for the room the item is in. People can get confused if the click on a "Click to view stream" link for an item that isn't currently on and see a different item. To avoid this confusion, we can now configure the streaming links to only be enabled during the item. Similarly, replays aren't typically available until after the item has finished. If no `WHEN` is configured, it is assumed to be always enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links can now be configured with whether they should be enabled before, during or after the item.
Sometimes streaming links aren't a link to the specific item, but to a stream for the room the item is in. People can get confused if the click on a "Click to view stream" link for an item that isn't currently on and see a different item. To avoid this confusion, we can now configure the streaming links to only be enabled during the item.
Similarly, replays aren't typically available until after the item has finished.
If no
WHENis configured, it is assumed to be always enabled.