Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jamesmoore/arch 224 silo support device groups #63

Open
wants to merge 114 commits into
base: main
Choose a base branch
from
Open

Jamesmoore/arch 224 silo support device groups #63

wants to merge 114 commits into from

Conversation

jimmyaxod
Copy link
Contributor

@jimmyaxod jimmyaxod commented Dec 13, 2024 •
edited
Loading

Draft PR for Silo/Drafter API refactor

@jimmyaxod
Added some scripts for testing branch dev
b246386 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Test working w hack/start hack/migrate
091c5c4 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Started pulling out silo bits for peer migrate_to
c1b0483 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Pulled out silo make_migratable bits
fa941b7 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Pulled out silo migrate_from (protocol)
1a552a2 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Pulled out migrate_from (fs) silo bits
1c45c0f 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Simplified migrate from local a little
7488186 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Split out shared devices from Silo devs
a167ee3 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Refactor silo dev schema for local
4498bac 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod jimmyaxod mentioned this pull request Dec 13, 2024
Closed
@jimmyaxod
migrate (local fs) now using silo.dg
9bef1ea 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Split initial migrate from dirty migrate phase
7ac2c55 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Little tidy
181f949 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Cleaned out make_migratable
6134366 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
renames
09f9827 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Simplification
9857d5c 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Little more refactor
684fc24 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Things kind of starting to work for some definition of work.
4f0b236 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Couple of tidy ups
9fc741d 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
WIP. Getting there... migrate works
b16febd 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Tidied up exposeSiloDeviceAsFile
23916bc 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Removed some stage vars
2fb88a3 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Removed more stage bits
aee7e85 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
More work
941e3c7 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Removed stage2Inputs
9978037 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Removed some unused hooks. Logging/metrics better
a15c767 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
More simplification
3a9b7c4 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Pulled out vm_state
cfe41d3 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Removed hack scripts for testing
742e9ae 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
First stab at dirty refactor
947fc00 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Tidied some default devs
00337cf 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Some tidying of snapshotter
ce12c3e 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Fixed graceful exit
e2b699e 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
WIP package_test
4c1ccaf 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Start on next couple of tests
947fb43 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Package test
eb0f1d6 
Signed-off-by: Jimmy Moore <[email protected]>
@pojntfx pojntfx mentioned this pull request Jan 25, 2025
Open
jimmyaxod and others added 23 commits January 27, 2025 14:19
@jimmyaxod
Extracted runtime provider from peer, and reinstated generic rpc impl…
d8aaa85 
… (PR74)

Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
RuntimeProvider correctly sets Remote after resume
3a163df 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Moved config/vsock port bit inside runtimeProvider
4d52498 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
First e2e peer migrate test working (No writes from vm)
395cdcc 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Tidied up log messages in peer
509be43 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Full e2e mocked vm migration with the vm writing data to devices duri…
5a84b3b 
…ng migration.

Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Added a bit more output on test
e74fdf7 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Reorg runtimes
2d137df 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Fixed shutdown behaviour hopefully within peer/runtime
096acb0 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Should fix RPC select bug #67 (comment)
0965ff0 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Added baseline config for S3 assisted Silo devices
90cd64c 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Can now expose silo prom metrics from drafter-peer
cdfc146 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Removed debug
e038c89 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Added a hook to MigrateFromHook for completion event
7324f32 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Fixed hang on connection close mid migration, added test
9863f99 
Signed-off-by: Jimmy Moore <[email protected]>
@pojntfx @jimmyaxod
fix: Don't try to access err in peer.go unless it's not-nil
be74f29 
Signed-off-by: Felicitas Pojtinger <[email protected]>
@jimmyaxod
Adjusted to call onComplete only on success. On error, the error will…
72c0061 
… appear on BackgroundErr chan

Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Added peer migrate using cow unit test
d18a8ee 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Added test for multiple migrations
1ec03b9 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
multi migration test failing due to not picking up dirty data
cbc7937 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Hack workaround write-path bug passes
f8e8443 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
bump silo to fix multi-migration issue, and added test
c519831 
Signed-off-by: Jimmy Moore <[email protected]>
@jimmyaxod
Little test tidy and removed printf from migrations
b8ddcd5 
Signed-off-by: Jimmy Moore <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShivanshVij ShivanshVij Awaiting requested review from ShivanshVij

@pojntfx pojntfx Awaiting requested review from pojntfx

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jimmyaxod @pojntfx