Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular dependencies in bindings #535

Closed
3 tasks done
bajtos opened this issue Aug 23, 2017 · 6 comments
Closed
3 tasks done

Circular dependencies in bindings #535

bajtos opened this issue Aug 23, 2017 · 6 comments
Assignees
Labels
Milestone

Comments

@bajtos
Copy link
Member

bajtos commented Aug 23, 2017

Detect circular class/provider dependencies and fail with a helpful error.

Acceptance criteria

  • The fix, make sure to handle both linear dependency hierarchy as well cross-leaf references in a tree of deps and include tests!
  • Documentation so that people can find more information about this problem when they see the error message.
  • A blog post
@raymondfeng
Copy link
Contributor

WIP at #671

@bajtos
Copy link
Member Author

bajtos commented Dec 15, 2017

WIP at #671

#671 adds more than just detection of circular dependencies, most notably withOptions method, and I am not sure we have agreed withOptions is the right approach to take.

@raymondfeng Could you please move the commit for circular dependencies to a standalone pull request?

@bajtos
Copy link
Member Author

bajtos commented Jan 18, 2018

@raymondfeng I think the first part was done by #852, could you please confirm?

  • The fix, make sure to handle both linear dependency hierarchy as well cross-leaf references in a tree of deps and include tests!

Could you please prioritize the remaining two parts so that we can close this issue as done soon?

  • Documentation so that people can find more information about this problem when they see the error message.
  • A blog post

@raymondfeng
Copy link
Contributor

See draft docs at loopbackio/loopback.io#588

@raymondfeng
Copy link
Contributor

Implemented by #852

@kjdelisle kjdelisle added this to the February 2018 milestone Jan 30, 2018
@raymondfeng
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants