Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update controller class in package rest-crud when id is a required property #3728

Closed
1 task
jannyHou opened this issue Sep 13, 2019 · 3 comments
Closed
1 task
Labels
developer-experience Issues affecting ease of use and overall experience of LB users feature stale

Comments

@jannyHou
Copy link
Contributor

jannyHou commented Sep 13, 2019

connect to #2036
This is a follow-up story of PR #3667.
As a quick fix, that PR fixes the controller generator by adding a new prompt isIdOmitted, and creating the corresponding controller class differently.

There are two more improvements which need more time to address, so I open a new issue here.

Suggestion

Update the controller class in @loopback/rest-crud to reflect the id property's configuration.

Acceptance criteria

  • Update the controller class in @loopback/rest-crud package, so that it generates the correct schema for id property. See discussion and discussion
@bajtos
Copy link
Member

bajtos commented Sep 13, 2019

(Not sure is it a good idea to do them in one story, or should I create two?)

Let's create two stories please.

@dhmlau dhmlau added the developer-experience Issues affecting ease of use and overall experience of LB users label Sep 18, 2019
@stale
Copy link

stale bot commented Sep 12, 2020

This issue has been marked stale because it has not seen activity within six months. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository. This issue will be closed within 30 days of being stale.

@stale stale bot added the stale label Sep 12, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.

@stale stale bot closed this as completed Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience Issues affecting ease of use and overall experience of LB users feature stale
Projects
None yet
Development

No branches or pull requests

3 participants