Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relation refactoring: Remove execute function out of Repository interface #1355

Closed
2 tasks
dhmlau opened this issue May 24, 2018 · 0 comments · Fixed by #1414
Closed
2 tasks

Relation refactoring: Remove execute function out of Repository interface #1355

dhmlau opened this issue May 24, 2018 · 0 comments · Fixed by #1414
Assignees
@shimks

Comments

@dhmlau
Copy link
Member

dhmlau commented May 24, 2018 •
edited by jannyHou
Loading

Description / Steps to reproduce / Feature proposal

Remove execute function out of Repository interface and into its own interface for arbitrary SQL commands. The reasoning behind this is that the Repository interface serves the base for a lot the repository interfaces and it doesn't make sense for some of them to also include the execute function. See #1194 (comment).

Acceptance Criteria

  • Move the execute function here for arbitrary SQL commands from the repository interface and into its own interface.
  • Move it to a separate file in @loopback/repository as a temporary solution.

See Reporting Issues for more tips on writing good issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shimks shimks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(repository): separate execute function from repository interface loopbackio/loopback-next
3 participants
@bajtos @shimks @dhmlau