Client cuts passwords at 47 chars

[lmoureaux]

The client uses MAX_LEN_NAME (=48) where it ought to be MAX_LEN_PASSWORD (=256 512):

freeciv21/client/gui-qt/page_network.cpp

Line 454 in 673c43d

MAX_LEN_NAME);

freeciv21/client/gui-qt/page_network.cpp

Line 442 in 673c43d

MAX_LEN_NAME);

Found by panch93

[DobbyK]

I found where MAX_LEN_PASSWORD is definite and it equals 512?

freeciv21/common/networking/connection.h

Line 42 in 80d2c15

#define MAX_LEN_PASSWORD \

Is this the correct place where it was defined and is it a mistake, or did you make a mistake?

[lmoureaux]

MAX_LEN_NAME in page_network.cpp is wrong, it should be MAX_LEN_PASSWORD.

[DobbyK]

MAX_LEN_NAME in page_network.cpp is wrong, it should be MAX_LEN_PASSWORD.

I don't think you understood my question, sorry. You said MAX_LEN_PASSWORD = 256, yet where (i assume/believe) it is definied, defines it as 512. Is that a mistake and should that be 256, or did you type it incorrectly?

[lmoureaux]

Oh sorry I mistyped, that's what named constants are for 😊 It should be MAX_LEN_PASSWORD regardless of its actual value.

[DobbyK]

I would suggest that we not have it equal 512 as that is a really long password, and even know if someone wanted it really secure could easily risk not being able to get into the account.

[lmoureaux]

A limit at 512 bytes doesn't hurt either... Changing it would break compatibility with existing clients and servers.

[DobbyK]

A limit at 512 bytes doesn't hurt either... Changing it would break compatibility with existing clients and servers.

Makes sense. #531 for fix then.