Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar does not show greyed dates from next/previous month #271

Open
vishnuvardan opened this issue Sep 1, 2016 · 7 comments
Open

Calendar does not show greyed dates from next/previous month #271

vishnuvardan opened this issue Sep 1, 2016 · 7 comments

Comments

@vishnuvardan
Copy link

The following is the screenshot taken from demo page http://longbill.github.io/jquery-date-range-picker/. It does not show the dates from other month.
image

Image from GitHub page shows disabled dates from other month:
image

@holtkamp
Copy link
Collaborator

holtkamp commented Sep 1, 2016

Mm, indeed, apparently default behavior has changed.

It seems there is an inconsistency between the CSS classes, here they are 'set':

.date-picker-wrapper .month-wrapper table div.day.lastMonth,
.date-picker-wrapper .month-wrapper table div.day.nextMonth
{
color:#999;
cursor:default;
}

And here they are set to 'nodisplay':

.date-picker-wrapper .month-wrapper table .day.nextMonth,
.date-picker-wrapper .month-wrapper table .day.lastMonth { display:none; }

Not sure why that last part is done. Anyone?

@vishnuvardan
Copy link
Author

Wow, thank you so much Menno Holtkamp :) You saved my day :)
Added the tweak for us :)

I am completely satisfied for the response. You can close the bug :)

@holtkamp
Copy link
Collaborator

holtkamp commented Sep 1, 2016

It seems this advice #38 has entered the repository using ad8aa84

@longbill remember why you did this?

@hbulens
Copy link

hbulens commented Oct 21, 2022

This still seems to be in the codebase. Did you ever got a response to this, @holtkamp?

@holtkamp
Copy link
Collaborator

@hbulens nope. Maybe we should make this configurable?

@hbulens
Copy link

hbulens commented Oct 21, 2022

That would be the cleanest way, yes. Although it would most definitely suffice to make it visible by default. Google Calendar, Outlook, and others all have those dates visible, so people aren't going to be surprised to see those dates appear in the calendar.

@holtkamp
Copy link
Collaborator

holtkamp commented Oct 21, 2022

I agree that displaying the dates of other months in greyed out approach seems like an accepted default mode.

@hbulens feel free to open a Pull Request.

Disclaimer: not sure if I will be able to release a new version, @monovertex released the last releases...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants