Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with addressable 2.8.2 #27

Closed
crevete opened this issue Apr 4, 2023 · 3 comments
Closed

Crash with addressable 2.8.2 #27

crevete opened this issue Apr 4, 2023 · 3 comments
Assignees

Comments

@crevete
Copy link

crevete commented Apr 4, 2023

Describe the bug

When upgrading addressable gem to 2.8.2, the following snippet fails:

require 'ruby_lokalise_api'
client = RubyLokaliseApi.client("<my_api_token>")
client.download_files("<my_project_id>", { ... })

The error message is: NoMethodError: undefined method 'to_str' for :projects:Symbol cf this line.

Please note that it works fine with addressable 2.8.1, and it does not hit that line (template.rb#L900).

Workaround

Fix the version of addressable to 2.8.1:

# Gemfile
gem 'addressable', "=2.8.1"`

Your environment:

  • OS : Ubuntu 22.04.2 LTS
  • Ruby version : 3.2.1
@crevete crevete added the bug Something isn't working label Apr 4, 2023
@bodrovis bodrovis removed the bug Something isn't working label Apr 4, 2023
@bodrovis
Copy link
Collaborator

bodrovis commented Apr 4, 2023

This is something not related to this gem, I believe. I would wait until this patch is merged and a new version is released sporkmonger/addressable#499

@crevete
Copy link
Author

crevete commented Apr 4, 2023

Nice, thanks!

@crevete crevete closed this as completed Apr 4, 2023
@bodrovis
Copy link
Collaborator

bodrovis commented Apr 4, 2023

It runs fine with 2.8.3 so hopefully all should be good https://github.com/lokalise/ruby-lokalise-api/actions/runs/4612637293/jobs/8153765072

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants