fix(react-i18next): show sub completion items when using scoped namespace #941

Angeart · 2023-06-08T20:02:04Z

This change resolve the following problems

show auto-complete correctly using a namespace with useTranslation and other specify namespace

Example case

Structure

locales/
  en/
    common.json
    login.json
  ja/
    common.json
    login.json

login.json

{
  "emailAddress": "Email Address",
  "password": "password",
  "rememberMe": "Remember me",
  "loginButton": "Sign in",
  "socialLoginButton": "Sign in with {{provider}}"
}

❌

✅

…pace

…pace (lokalise#941) * fix(react-i18next): show sub completion items when using scoped namespace * Empty commit to trigger CI --------- Co-authored-by: Alex Terehov <[email protected]>

fix(react-i18next): show sub completion items when using scoped names…

0bb2bd0

…pace

Angeart requested review from terales, kibertoad and anilkk as code owners June 8, 2023 20:02

Angeart changed the title ~~fix(react-i18n): show sub completion items when using scoped namespace~~ fix(react-i18next): show sub completion items when using scoped namespace Jun 9, 2023

terales approved these changes Aug 27, 2023

View reviewed changes

Empty commit to trigger CI

7ab27b9

terales merged commit fb8a429 into lokalise:main Aug 27, 2023

aranard mentioned this pull request Aug 30, 2023

There is a mismatch in next-i18next #996

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(react-i18next): show sub completion items when using scoped namespace #941

fix(react-i18next): show sub completion items when using scoped namespace #941

Angeart commented Jun 8, 2023

fix(react-i18next): show sub completion items when using scoped namespace #941

fix(react-i18next): show sub completion items when using scoped namespace #941

Conversation

Angeart commented Jun 8, 2023

Example case