fix(vue-i18n): Allow additional attributes on i18n component #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terales
approved these changes
Aug 27, 2023
huacnlee
pushed a commit
to huacnlee/i18n-ally
that referenced
this pull request
Aug 28, 2023
…e#865) * fix(vue-i18n): Allow additional attributes on i18n component * dont allow whitespace before/after "=", allow lf after attr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #864
Is there a reason the
\nis not escaped in the regex? All other occurrences of\are escaped.Also: How do I add tests for this change?
// EDIT: I assume there was a typo in the rejex and the stray
(in front of\nwas meant to be an\so I changed it accordingly