fix: Transloco scope detection #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
not stale |
openscript
added a commit
to openscript-ch/i18n-ally-fork
that referenced
this pull request
Jan 21, 2022
This is related to: lokalise#682 lokalise#684
4 tasks
|
This needs to be fixed |
Predhin
approved these changes
May 16, 2023
ghaschel
approved these changes
May 16, 2023
ghaschel
approved these changes
May 16, 2023
camilathomasi
approved these changes
May 16, 2023
BruneXX
approved these changes
May 16, 2023
terales
approved these changes
May 18, 2023
|
Thanks @terales ! :) |
|
FYI: The updated regex has issue if there are linebreaks between the function arguments |
huacnlee
pushed a commit
to huacnlee/i18n-ally
that referenced
this pull request
Aug 28, 2023
* Update Transloco documentation hints * Fix comment typo * Implement scopes/namespaces for Transloco
|
@terales It still doesn't work with Angular and per-module scopes. Would providing a StackBlitz be helpful to you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Transloco scope detection according to their documentation (#682)