Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash recovery now respects retry_count and retry_delay #254

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chrisboulton
Copy link

We noticed that during crash recovery the configurable retry settings (count and delay) were not respected. I wasn't sure if there was a reason for this, but if not this PR addresses that behaviour.

Previously while performing crash recovery:

[2023-01-31T17:32:53,179][WARN ][logstash.outputs.s3      ] Uploading failed, retrying (#78 of Infinity) {:exception=>Aws::S3::Errors::AccessDenied,...

Now:

[2023-01-31T17:52:00,265][WARN ][logstash.outputs.s3      ] Uploading failed, retrying (#3 of 50) {:exception=>Aws::S3::Errors::AccessDenied, :message=>"Access Denied",...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants