Add option to skip validation when dealing with schema registry #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a `validate_schema_registry` option to the plugin, allowing users to bypass the schema registry validation while using a plugin. This is a common issue when using authenticated schema registry, as the validation occurs outside of the 'KafkaConsumer' code, and will require considerable effort to maintain parity with that method. This configuration option has 2 settings `auto` and `skip`. The default `auto` setting will skip validation when schema registry auth is used that is known to fail, currently when Kerberos authentication is used, but will try and validate in other cases. `skip` will skip regardless of authentication method.
yaauie
reviewed
Jul 12, 2021
| [id="plugins-{type}s-{plugin}-validate_schema_registry"] | ||
| ===== `schema_registry_validation` | ||
|
|
||
| * Value can be either of: `auto`, `skip` |
There was a problem hiding this comment.
👍🏼 I like the auto/skip here. It conveys the complexity a lot better than a true/false would, and similarly doesn't convey promises that we will validate it (if it isn't set, or we can't validate) or that we won't ever do so (e.g., when we start using it and it doesn't provide what we need).
Co-authored-by: Ry Biesemeyer <[email protected]>
karenzone
requested changes
Jul 12, 2021
There was a problem hiding this comment.
Anchors don't match between the table and description, and would crash the docs build. Pick your favorite.
I left suggested wording inline for your consideration. We do some of our best work when we iterate, so your suggestions to my suggestions are welcome (as always). :-)
Co-authored-by: Karen Metts <[email protected]>
karenzone
changed the title
|
@karenzone I've made the changes, ready for another round |
This was referenced Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
validate_schema_registryoption to the plugin, allowingusers to bypass the schema registry validation while using a plugin. This is
a common issue when using authenticated schema registry, as the validation occurs
outside of the 'KafkaConsumer' code, and will require considerable effort to maintain
parity with that method.
This configuration option has 2 settings
autoandskip. The defaultautosettingwill skip validation when schema registry auth is used that is known to fail, currently
when Kerberos authentication is used, but will try and validate in other cases.
skipwill skip regardless of authentication method.
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/