Fix nil exception to empty headers during metadata assignment #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaisecheng
changed the title
andsel
requested changes
Feb 16, 2023
lib/logstash/inputs/kafka.rb
Outdated
| @@ -374,6 +374,8 @@ def maybe_set_metadata(event, record) | |||
| end | |||
| if @metadata_mode.include?(:headers) | |||
| record.headers.each do |header| | |||
| next if header.nil? || header.value.nil? || header.key.nil? | |||
There was a problem hiding this comment.
I tried to comment this line and ran the test, but was still green. Seems the test doesn't enter the loop.
There was a problem hiding this comment.
Great that you spot it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #141
This commit guard nil exception in metadata assignment