v4.1.1 : crash at startup

[fbaligand]

When I launch Logstash v6.1.1, with logstash-file-input v4.1.1 on Windows 10, I get thi blocking error which crashes Logstash :

[2018-05-01T18:56:43,393][ERROR][logstash.plugins.registry] Tried to load a plugin's code, but failed. {:exception=>#<LoadError: no such file to load -- winhelper>, :path=>"logstash/inputs/file", :type=>"input", :name=>"file"}
[2018-05-01T18:56:43,424][ERROR][logstash.agent           ] Failed to execute action {:action=>LogStash::PipelineAction::Create/pipeline_id:main, :exception=>"LogStash::PluginLoadingError", :message=>"Couldn't find any input plugin named 'file'. Are you sure this is correct? Trying to load the file input plugin resulted in this error: no such file to load -- winhelper", :backtrace=>["C:/Developpement/outils/logstash/logstash-6.1.1/logstash-core/lib/logstash/plugins/registry.rb:192:in `lookup_pipeline_plugin'", "C:/Developpement/outils/logstash/logstash-6.1.1/logstash-core/lib/logstash/plugin.rb:140:in `lookup'", "C:/Developpement/outils/logstash/logstash-6.1.1/logstash-core/lib/logstash/plugins/plugin_factory.rb:82:in `plugin'", "C:/Developpement/outils/logstash/logstash-6.1.1/logstash-core/lib/logstash/pipeline.rb:114:in `plugin'", "(eval):8:in `<eval>'", "org/jruby/RubyKernel.java:994:in `eval'", "C:/Developpement/outils/logstash/logstash-6.1.1/logstash-core/lib/logstash/pipeline.rb:86:in `initialize'", "C:/Developpement/outils/logstash/logstash-6.1.1/logstash-core/lib/logstash/pipeline.rb:171:in `initialize'", "C:/Developpement/outils/logstash/logstash-6.1.1/logstash-core/lib/logstash/pipeline_action/create.rb:40:in `execute'", "C:/Developpement/outils/logstash/logstash-6.1.1/logstash-core/lib/logstash/agent.rb:335:in `block in converge_state'", "C:/Developpement/outils/logstash/logstash-6.1.1/logstash-core/lib/logstash/agent.rb:141:in `with_pipelines'", "C:/Developpement/outils/logstash/logstash-6.1.1/logstash-core/lib/logstash/agent.rb:332:in `block in converge_state'", "org/jruby/RubyArray.java:1734:in `each'", "C:/Developpement/outils/logstash/logstash-6.1.1/logstash-core/lib/logstash/agent.rb:319:in `converge_state'", "C:/Developpement/outils/logstash/logstash-6.1.1/logstash-core/lib/logstash/agent.rb:166:in `block in converge_state_and_update'", "C:/Developpement/outils/logstash/logstash-6.1.1/logstash-core/lib/logstash/agent.rb:141:in `with_pipelines'", "C:/Developpement/outils/logstash/logstash-6.1.1/logstash-core/lib/logstash/agent.rb:164:in `converge_state_and_update'", "C:/Developpement/outils/logstash/logstash-6.1.1/logstash-core/lib/logstash/agent.rb:90:in `execute'", "C:/Developpement/outils/logstash/logstash-6.1.1/logstash-core/lib/logstash/runner.rb:343:in `block in execute'", "C:/Developpement/outils/logstash/logstash-6.1.1/vendor/bundle/jruby/2.3.0/gems/stud-0.0.23/lib/stud/task.rb:24:in `block in initialize'"]}

I guess it is because in the folder "logstash-input-file/lib/logstash/inputs", there are both "file.rb" file and "file" folder.
And maybe it is specific to Windows ?

[guyboertje]

Yes it is specific to Windows. Damn.

[guyboertje]

bootstrap.rb line 40 should be require_relative.

[fbaligand]

I confirm that with this fix, my problem is solved.
=> Could you fix plugin code on master branch ?

[guyboertje]

@fbaligand
I will but there is another serious bug #185 that happens when the delimiter is not found in a chunk.
I will fix both.

[fbaligand]

Ok, Nice !

[fbaligand]

Great ! Thanks @guyboertje !

[fbaligand]

I just tested v4.1.1 => it works great !