-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KV filter dropping existing fields in target object v2.0.2 -> v2.0.3 #43
Comments
This happens in 5.4.1 as well. |
This is still happening in kv filter version I worked around it for now with something like:
|
submitted PR #69 to fix this regression. This regression has made it through 2 major versions of the plugin but nonetheless I think it makes sense to not loose existing fields in the target if it exists. |
I do have the exact same problem. |
I can confirm that this issue is still present:
|
Having this exact same problem. |
I didn't confirm this, but my suspicion is that the changes in the following commit seems to override any fields in the target object for the KV filter: refactor field refereces to not rely on in-place mutability. @colinsurprenant @ph
In my particular case, I add a few fields to an object in a grok filter, then I run the KV filter targeting that object to add the KV fields to the object. In version 2.0.2, the plugin does not drop the existing fields, in version 2.0.3, the plugin drops any fields in the target object before adding the KV pairs as fields.
[object]
as a target for the KV filter:What happens is the new key values exist in the
[object]
, but existing fields[field1]
and[field2]
in the object are dropped.The text was updated successfully, but these errors were encountered: