Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsapi is not open-source #9311

Closed
1 of 2 tasks
george-hopkins opened this issue May 4, 2023 · 17 comments
Closed
1 of 2 tasks

rsapi is not open-source #9311

george-hopkins opened this issue May 4, 2023 · 17 comments
Assignees
Labels
:type/question Not bug, closed at will. Frequently asked ones would be collected in Logseq Forum's FAQ section.

Comments

@george-hopkins
Copy link

Search first

  • I searched and no similar issues were found

What Happened?

Logseq contains a Node.js library @logseq/rsapi which is not open source. Amongst other things, this component seems to be essential to the encryption scheme (rsapi/ageEncryptWithPassphrase). This hinders the inspection of these methods considerably. In addition, the project no longer adheres to the AGPL.

Reproduce the Bug

@logseq/rsapi can not be built from scratch

Expected Behavior

rsapi is open-sourced and the project is fully AGPL-compatible

Screenshots

No response

Desktop or Mobile Platform Information

all platforms

Additional Context

#8870

Are you willing to submit a PR? If you know how to fix the bug.

  • I'm willing to submit a PR (Thank you!)
@cnrpman cnrpman added the :type/question Not bug, closed at will. Frequently asked ones would be collected in Logseq Forum's FAQ section. label May 7, 2023
@cnrpman
Copy link
Collaborator

cnrpman commented May 7, 2023

open-sourcing rsapi is on the plan.
cc. @andelf

@intzaaa
Copy link

intzaaa commented Jun 13, 2023

image

It has been a month, is it difficult to open source a module? Where are you stuck?

@cnrpman
Copy link
Collaborator

cnrpman commented Jun 13, 2023

@huangyinhaow Sorry. I will ping the team for the update on the progress

@intzaaa
Copy link

intzaaa commented Jun 13, 2023

@huangyinhaow Sorry. I will ping the team for the update on the progress

Thanks for your prompt reply! Hope you can close this issue soon!

@cnrpman
Copy link
Collaborator

cnrpman commented Jun 28, 2023

We are planing to open-source when the recent diff-merge feature is stabled.
#9238
#9748

As a software curated in the FOSS community, we always know the importance of local-first, privacy & E2EE. And we have many nice observers from the community.
Many doc stuff are not prepared as the Logseq Sync is still in beta and under rapid change, but in the formal launch it will be shipped with open-sourced client-side codebase and tech document coverage. We are also pushing our process on GDPR certificating.
There are too many stuff to do, and it could be a bit overwhelming for a small team. But Logseq Sync is strictly following E2EE and we are on the track to improve the transparency to users (especially non-techs)

@arrowd
Copy link

arrowd commented Sep 22, 2023

Just bumped into this when trying to run Logseq on FreeBSD:

Error: Cannot find module '@logseq/rsapi-freebsd-x64'

Waiting for opensourcing too.

@intzaaa
Copy link

intzaaa commented Sep 29, 2023

Any updates?

@arrowd
Copy link

arrowd commented Oct 27, 2023

Any movement on this?

@fivestones
Copy link

We are planing to open-source when the recent diff-merge feature is stabled.
#9238
#9748

It looks like these were both merged about 4 months ago. Is there any update on this?

I found this: https://www.npmjs.com/package/@logseq/rsapi?activeTab=code
Is it the code in question? It seems to have been open sourced as MIT 2 months ago.

@george-hopkins
Copy link
Author

@fivestones It looks like it's still closed source. The package you mentioned is just a wrapper around platform-specific binaries (e.g. @logseq/rsapi-linux-x64-gnu)

@fivestones
Copy link

@george-hopkins Yeah you're right.
@cnrpman

@andelf andelf self-assigned this Nov 2, 2023
@andelf
Copy link
Collaborator

andelf commented Nov 2, 2023

Thanks for your reminder.

It takes time to filter out old commits, which might contain secret keys or credentials for historical reasons.

So I just strip out old commits. Sorry for the inconvenience. Check it at https://github.com/logseq/rsapi

Regarding the Logseq Sync implementation, the underlying code is not confidential. You can find the Swift implementation of the iOS version on GitHub, which is open-source.

See-also: #10449

@andelf
Copy link
Collaborator

andelf commented Nov 2, 2023

Close as resolved.

@andelf andelf closed this as completed Nov 2, 2023
@fivestones
Copy link

Thanks @andelf!

@bcspragu
Copy link

bcspragu commented Nov 4, 2023

Also just wanted to say thanks for taking the time to open-source this, it's much appreciated!

@arrowd
Copy link

arrowd commented Nov 6, 2023

Just as another gratitude for open sourcing this, it allowed me to create a port of Loqseq for FreeBSD. My port will land FreeBSD Ports tree in a couple of days.

@brokenpip3
Copy link

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:type/question Not bug, closed at will. Frequently asked ones would be collected in Logseq Forum's FAQ section.
Projects
None yet
Development

No branches or pull requests

8 participants