Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(4.6): Allow mutating field array iterable's value property #3618

Merged
merged 3 commits into from
Jan 29, 2022

Conversation

logaretm
Copy link
Owner

What

This PR implements an enhancement for the FieldArray or useFieldArray where it wasn't possible to use v-model with it to mutate the iterable value directly.

The motivation for that design is to force the lib user to go through the API, however, it doesn't seem necessary to have this restriction as v-model is an initiative way to mutate such values.

This was mentioned in #3617 discussion

@logaretm logaretm changed the title feat(4.6): Allow mutating feat(4.6): Allow mutating field array iterable's value property Dec 14, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2022

Codecov Report

Merging #3618 (8ca61e3) into v4.6 (f48f348) will increase coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             v4.6    #3618      +/-   ##
==========================================
+ Coverage   96.34%   96.57%   +0.22%     
==========================================
  Files          68       68              
  Lines        1834     1840       +6     
  Branches      457      458       +1     
==========================================
+ Hits         1767     1777      +10     
+ Misses         67       63       -4     
Impacted Files Coverage Δ
packages/vee-validate/src/useFieldArray.ts 94.11% <100.00%> (+3.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f48f348...8ca61e3. Read the comment docs.

@logaretm logaretm merged commit 03b019e into v4.6 Jan 29, 2022
@logaretm logaretm deleted the feat/allow-mutating-array-field-value branch January 29, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants