Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Locust master doesn't remove killed slave #951

Closed
mangatmodi opened this issue Jan 23, 2019 · 1 comment
Closed

Bug: Locust master doesn't remove killed slave #951

mangatmodi opened this issue Jan 23, 2019 · 1 comment

Comments

@mangatmodi
Copy link

Description of issue / feature request

I am using boomer client to write my slave and master is having a dummy python file:
from locust import Locust, TaskSet, task

class DummyTaskSet(TaskSet):
    @task()
    def dummy_pass(self):
        pass

class Dummy(Locust):
    task_set = DummyTaskSet

However if my slave crashed, or I kill it from terminal the master still shows the slave connected.

Expected behavior

The locust master should mark the slave as gone, but it keeps pilling up. I believe it will impact my test as the load will be distributed between slaves which are non existent

Actual behavior

The locust master doesn't remove killed slave

Environment settings (for bug reports)

  • OS
  • Python version:
  • Locust version:

Running in Docker with following:-

FROM python:3.7

#install locust
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y build-essential libncursesw5-dev libreadline-dev libssl-dev libgdbm-dev libc6-dev libsqlite3-dev libxml2-dev libxslt-dev python python-dev python-setuptools && apt-get clean
RUN pip install locustio pyzmq

COPY run.sh /run.sh
COPY ./locustfile.py /locustfile.py
RUN chmod 755 /run.sh

EXPOSE 5557 5558 8089
CMD ["/run.sh"]

Steps to reproduce (for bug reports)

Already shared the Dockerfile and dummy locust file above. Following is my run file

#!/bin/bash
LOCUST_CMD="/usr/local/bin/locust"
LOCUST_DUMMY="/locustfile.py"
echo -n "=> Starting locust "
CMD="$LOCUST_CMD --master -f $LOCUST_DUMMY --csv=$OUT_FILE"
echo "$CMD"
$CMD

I have to clean up my slave code as I am underway to make it opensource, but an example from the author will work out of the box.

I think it is a locust master issue as no matter what happened with my slave, master should check with heartbeats that which slave is up?

Thanks,

@mangatmodi
Copy link
Author

Sorry my bad, it is already here -> #927.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant