locust/test/test_average.py present but never run

[sanga]

Consequently it fails in trunk. I suspect it's probably been failing for a long time. There's not much point in having a test suite if it never runs, it just confuses people like me, when they happen to use another test runner and notice that tests are failing in trunk ;)

I have a branch that kills that file and also one that makes it work. Which would you rather?

[heyman]

Ah, good find.

I'm no sure. From the comments in test_average.py, it says that the tests might fail (due to randomness). What is the likelihood of them failing? If it's possible to modify them so that the likelihood is extremely small (to the point where they're almost deterministic in practice, while still testing something useful), I think the working one would be great :).

[sanga]

After a brief test I conclude that it'll fail relatively often. Maybe 10-20% of the time. Certainly way to much to be enabled in trunk as it is.

[EnTeQuAk]

I enabled test_average for now in #86 but I agree that the test should be reworked to only fail or succeed without the current randomness. Still I think having a test is better than no one.

[sanga]

Well I'll close this case anyway. It's misleading as it is, as those tests are being run in trunk after @EnTeQuAk 's branch
got in (thanks btw).