Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset failures and/or exceptions #826

Closed
Exide opened this issue Jun 21, 2018 · 4 comments
Closed

Reset failures and/or exceptions #826

Exide opened this issue Jun 21, 2018 · 4 comments

Comments

@Exide
Copy link
Contributor

Exide commented Jun 21, 2018

Feature request

An HTTP endpoint for resetting "failures" and/or "exceptions". Currently you can send a POST request to http://locust-host/stats/reset but the "failures" and "exceptions" remain.

If it makes sense to have the existing endpoint also reset these then I am ok with that. Otherwise, having a new endpoint for this would also work. For consistency sake I can see keeping the POST method but DELETE might make more sense.

e.g. curl -X DELETE http://locust-host/failures

Thoughts?

I would be willing to submit a PR once we agree on the correct approach.

@cgoldberg
Copy link
Member

I think the POST to http://locust-host/stats/reset should also reset failures/exceptions.

@aldenpeterson-wf
Copy link
Contributor

I agree that reseting stats in general should do so, it almost feels like a bug to me if it doesn't.

@Exide
Copy link
Contributor Author

Exide commented Jul 13, 2018

Cool. I'll put together a PR once I'm back from vacation. Thanks for chiming in!

@aldenpeterson-wf
Copy link
Contributor

Addressed in #1000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants