Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to define the heartbeat liveness from the cmdline #1787

Closed
motybz opened this issue Jun 14, 2021 · 3 comments
Closed

Enable to define the heartbeat liveness from the cmdline #1787

motybz opened this issue Jun 14, 2021 · 3 comments
Labels
feature request stale Issue had no activity. Might still be worth fixing, but dont expect someone else to fix it

Comments

@motybz
Copy link

motybz commented Jun 14, 2021

I found out that a long time ago the service had an ability to define the heartbeat liveness from the cmdline but this commit removes this ability.

I think that in order to be a generic service the "heartbeat liveness" should be configurable.
In the current behavior, if I have a bug that slows the process I can't even understand it from the test results.

Describe the solution you'd like

Add the following flag
--heartbeat-liveness

Describe alternatives you've considered

I made a workaround and it works for me
import locust.runners locust.runners.HEARTBEAT_LIVENESS = 30

@cyberw
Copy link
Collaborator

cyberw commented Jun 14, 2021

We have a couple of these "internal" settings I think. IMO, they deserve command line settings, but the list of settings is already super long.

Perhaps we could divide settings into "normal" and "advanced"? I'm not sure what is the best way to it and I am sure I dont have time to do it myself, but maybe someone else could investigate.

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale Issue had no activity. Might still be worth fixing, but dont expect someone else to fix it label Aug 14, 2021
@github-actions
Copy link

This issue was closed because it has been stalled for 10 days with no activity. This does not necessarily mean that the issue is bad, but it most likely means that nobody is willing to take the time to fix it. If you have found Locust useful, then consider contributing a fix yourself!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request stale Issue had no activity. Might still be worth fixing, but dont expect someone else to fix it
Projects
None yet
Development

No branches or pull requests

2 participants