Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove step load feature now that LoadTestShape is possible? #1575

Closed
max-rocket-internet opened this issue Sep 29, 2020 · 5 comments · Fixed by #1584
Closed

Remove step load feature now that LoadTestShape is possible? #1575

max-rocket-internet opened this issue Sep 29, 2020 · 5 comments · Fixed by #1584
Labels
feature request hacktoberfest See https://hacktoberfest.digitalocean.com for more info

Comments

@max-rocket-internet
Copy link
Contributor

This was mentioned by @heyman and it would clean things up a bit. But since settings for LoadTestShape are entirely in the locust file, it has these down sides:

  • No option to pass step-load parameters via the UI
  • No option to pass step-load parameters via command line
@cyberw
Copy link
Collaborator

cyberw commented Sep 29, 2020

I'm +1. If you make the PR I will approve it. No need to keep it around as deprecated even, as it hasnt been in the code base for very long. But give an explanatory error message if --step-load is passed.

@cyberw cyberw added the hacktoberfest See https://hacktoberfest.digitalocean.com for more info label Sep 29, 2020
@max-rocket-internet
Copy link
Contributor Author

OK. I'll get to it sooner or later. Or if someone else wants to do it sooner, feel free.

@cyberw
Copy link
Collaborator

cyberw commented Oct 1, 2020

@max-rocket-internet Do you think you'll have time to do this? I would like to make a new release soon, and would prefer to do this first.

@max-rocket-internet
Copy link
Contributor Author

I will have time but not for 1-2 weeks.

@cyberw
Copy link
Collaborator

cyberw commented Oct 1, 2020

Ok, I'll make a note here if I start working on it. Maybe we'll do it for next release instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request hacktoberfest See https://hacktoberfest.digitalocean.com for more info
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants