Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set locust parameters via env vars & config file #1166

Closed
cyberw opened this issue Nov 20, 2019 · 4 comments
Closed

Set locust parameters via env vars & config file #1166

cyberw opened this issue Nov 20, 2019 · 4 comments

Comments

@cyberw
Copy link
Collaborator

cyberw commented Nov 20, 2019

It would be useful to be able to set locust's command line parameters via env vars (particularly to be able to provide defaults, to shorten the command that you have to type).

I suggest we use LOCUST_ for env vars.

Command line should override env vars of course.

I can make a PR if this sounds good to everyone. I'd probably use https://pypi.org/project/ConfigArgParse/ to do it.

@heyman
Copy link
Member

heyman commented Nov 20, 2019

I can't think of any drawbacks so I'm +1/+0.

@cyberw
Copy link
Collaborator Author

cyberw commented Nov 20, 2019

PR:ed. What does +0 mean? :)

@heyman
Copy link
Member

heyman commented Nov 20, 2019

What does +0 mean? :)

I believe it's the Django project that uses it (or at least used to use it) to indicate that you are positive to something, but don't feel strongly about it (it wouldn't matter so much to you that you're willing to champion it). I think they have the policy that a -0 (or -1 obviously) from any core developer would have to be converted to a +0 or +1 before it can get implemented.

@cyberw
Copy link
Collaborator Author

cyberw commented Nov 28, 2019

Fixed!

@cyberw cyberw closed this as completed Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants