line endings

[sanga]

This quite a nit-picky thing and in no way should effect the functionality of locust, but it's just something I see all the time when doing git diff (I have git diff to scream at me when it sees trailing whitespace so I don't accidentally leave it in). It seems like the there a mix of unix and windows file endings in locust (i.e. CRLF v LF). Any objection if I were to standardise on unix?

[heyman]

I agree we should definitely go with only Unix lien endings from now. The CRLF line endings is a legacy from using badly configured editors in the beginning of Locust's development. However, even though it's an annoyance, my current stand on this has been that it's not worth messing up the GIT history by doing a large whitespace fix commit, but we should try to make sure all changes use LF line endings.

[sanga]

OK. Fair enough. Actually I was going to follow up the line endings PR with a PR to remove trailing whitespace (of which there's also a bit in locust). I guess based on your reply that you're not keen for those kinds of "bulk cleanup" commits and would rather those kinds of things were cleaned up bit by bit in the context of other "real" commits?

[Jahaja]

So shall we bite the bullet and make the change? @heyman @cgbystrom

I'm not sure what the great loss is in regards to the git history?

[heyman]

Ok, it's now done in: a58c469, and .gitattributes is updated as well in: e215516

[sanga]

👍 thanks!