Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile errors in generated shuttle.rs #1164

Closed
hulk-higakijin opened this issue Jan 9, 2025 · 2 comments
Closed

Compile errors in generated shuttle.rs #1164

hulk-higakijin opened this issue Jan 9, 2025 · 2 comments
Milestone

Comments

@hulk-higakijin
Copy link
Contributor

Description
I tried to deploy loco app to shuttle, so I generate shuttle.rs with using cargo loco g deployment --kind shuttle.

This file have 2 errors.

this function takes 3 arguments but 2 arguments were supplied

  1. the trait bound shuttle_axum::AxumService: std::convert::From<axum::routing::Router> is not satisfied
    the trait std::convert::From<axum::routing::Router> is implemented for shuttle_axum::AxumService
    for that trait implementation, expected axum::routing::Router, found axum::routing::Router
    required for axum::routing::Router to implement std::convert::Into<shuttle_axum::AxumService>
Screenshot 0007-01-09 at 23 23 19

To Reproduce
cargo loco g deployment --kind shuttle
specify shuttle's version from '0.46.0' to '0.50.0'

Expected Behavior
fix compile errors

Environment:

~ on  master [?] is 📦 v1.0.0 via 🥟 v1.1.26 via  v22.5.1 
❯ cargo --version
cargo 1.83.0 (5ffbef321 2024-10-29)

~ on  master [?] is 📦 v1.0.0 via 🥟 v1.1.26 via  v22.5.1 
❯ rustc --version  
rustc 1.83.0 (90b35a623 2024-11-26)

~ on  master [?] is 📦 v1.0.0 via 🥟 v1.1.26 via  v22.5.1 
❯ loco --version
loco 0.14.0

Additional Context
related #1143

@kaplanelad kaplanelad added this to the 0.14.1 milestone Jan 12, 2025
@kaplanelad
Copy link
Contributor

Thanks @hulk-higakijin.
Issued fix in this PR

@kaplanelad
Copy link
Contributor

Changes have been merged and will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants