Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Remove event dispatcher #1487

Closed
5 tasks done
diegoeis opened this issue Jun 17, 2015 · 2 comments
Closed
5 tasks done

Remove event dispatcher #1487

diegoeis opened this issue Jun 17, 2015 · 2 comments
Assignees
Milestone

Comments

@diegoeis
Copy link
Contributor

We will not use anymore the event dispatcher inside LocaStyle for now...
However, don't need to remove the file _event-dispatcher.js. Just remove the call to this script.

We need to remove the scripts that are using this dispatcher too.

  • Remove links to docs event-dispatcher.html.erb (don't need the files, just remove the reference links of docs)
  • Remove reference of dispatcher on docs of Modal: modal.html.erb
  • Remove reference of dispatcher on docs of Collapse: collapse.html.erb
  • Remove script using this dispachter: collapse_spec.js
  • Remove/disable jasmine test event-dispatcher_spec.js
@diegoeis diegoeis added this to the 3.7.6 milestone Jun 17, 2015
@diegoeis diegoeis modified the milestones: 3.7.6, 3.7.5 Jul 7, 2015
@palloi palloi self-assigned this Jul 8, 2015
@palloi palloi self-assigned this Jul 17, 2015
@locaweb locaweb locked and limited conversation to collaborators Jul 17, 2015
@palloi
Copy link
Contributor

palloi commented Jul 17, 2015

Waiting pull request of other modules.

@diegoeis
Copy link
Contributor Author

I Think this can be closed. The another PR changing the events was approved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants