Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loop in polygonizer issue 874 #968

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Fix infinite loop in polygonizer issue 874 #968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
18cea50
Merge pull request #1 from locationtech/master
mukoki Aug 15, 2020
dd04203
Merge pull request #2 from locationtech/master
mukoki Aug 27, 2020
6bb5ae7
Merge pull request #3 from locationtech/master
mukoki Aug 31, 2020
2681c3f
Merge pull request #4 from locationtech/master
mukoki Mar 23, 2021
df5d234
Merge remote-tracking branch 'origin/master'
mukoki May 22, 2022
832a19b
Merge branch 'locationtech:master' into master
mukoki Mar 1, 2023
deb75a7
Fix infinite loop in polygonizer (issue #874)
mukoki Mar 1, 2023
b38f725
Merge branch 'locationtech:master' into master
mukoki Mar 7, 2023
dfd88a4
Merge branch 'locationtech:master' into master
mukoki Mar 14, 2023
c7284b9
Merge remote-tracking branch 'origin/master' into fix_infinite_loop_i…
mukoki Mar 14, 2023
e0b732e
improve message and add simple test
mukoki Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions modules/core/src/main/java/org/locationtech/jts/operation/polygonize/Polygonizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,16 +296,23 @@ private static void findDisjointShells(List<EdgeRing> shellList) {
findOuterShells(shellList);

boolean isMoreToScan;
int lastUnsetNumber = -1;
do {
isMoreToScan = false;
int unsetNumber = 0;
for (EdgeRing er : shellList) {
if (er.isIncludedSet())
continue;
unsetNumber++;
er.updateIncluded();
if (! er.isIncludedSet()) {
isMoreToScan = true;
}
}
if (unsetNumber > 0 && unsetNumber == lastUnsetNumber) {
throw new IllegalStateException("Failed to polygonize with extractOnlyPolygonal option : input may not be correctly noded");
}
lastUnsetNumber = unsetNumber;
} while (isMoreToScan);
}

Expand Down
Loading