Fix vertex intersection in OverlayArea
#1043
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tanelk <[email protected]>
Signed-off-by: tanelk <[email protected]>
Signed-off-by: tanelk <[email protected]>
Signed-off-by: tanelk <[email protected]>
|
Did not change |
Signed-off-by: tanelk <[email protected]>
Signed-off-by: tanelk <[email protected]>
tanelk
changed the title
OverlayAreaOverlayArea
Signed-off-by: tanelk <[email protected]>
Signed-off-by: tanelk <[email protected]>
Signed-off-by: tanelk <[email protected]>
Signed-off-by: tanelk <[email protected]>
Signed-off-by: tanelk <[email protected]>
# Conflicts: # modules/lab/src/main/java/org/locationtech/jts/operation/overlayarea/OverlayArea.java
Signed-off-by: tanelk <[email protected]>
|
I went ahead and fixed the |
|
Pinging @dr-jts for a review on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second try at fixing
OverlayArea.It seems to me, that vertex-vertex intersection could not be done, when only looking at pairs of edges. Instead all four have to be looked at together.
For this I replaced
STRtreewithSegmentSetMutualIntersector, because it has access to previous and next segments on both lines.Added several new test cases and moved common ones into a shared base for simple and regular overlay area tests.
Covers #1040 and #1042