update bitnami commons version, introduce semver range #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfangl
approved these changes
Aug 31, 2023
|
If I'm not mistaken, the dependencies are packaged with the chart itself. The lock file pins the exact version of a dependency. So without performing I'll merge this PR for now, but we can continue the discussion here. |
|
@alexrashed TY for the quick turnaround, I've pulled down the latest release and confirmed issue is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #92, the chart's dependency on bitnami's common chart is quite outdated. This can cause issues when this chart is again used as a dependency with other library charts using the commons in a different version, leading to conflicting or at least a non-deterministic selection of transitive dependencies (as outlined in helm/helm#11561).
This PR sets the dependency version to a version range:
^2.9.0.We only have to regularly run
helm dependency updateand re-commit the generated lock file to update the chart (within updates in the major version2). I might start looking into GitHub actions to automatically update the lock file when new versions of the chart are released.Thanks @mjasnowski for the great issue report, making us aware of the issue and describing the background.
Fixes #92