Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.6.3 no longer works with Helm 3.5.4 #94

Closed
kerwinyoder opened this issue Sep 1, 2023 · 5 comments
Closed

Release 0.6.3 no longer works with Helm 3.5.4 #94

kerwinyoder opened this issue Sep 1, 2023 · 5 comments
Assignees
Labels
type: bug Bug relating to a chart in this repo

Comments

@kerwinyoder
Copy link

Thanks for your work on this project! Unfortunately it appears 0.6.3 no longer works with older versions of Helm, specifically 3.5.4. Installing the chart causes the following parse error.

Error: parse error at (localstack/charts/common/templates/_labels.tpl:14): unclosed action

The error does not occur on 0.6.2.

The documentation says LocalStack requires 3.2.0+. If this was an intentional change, you'll likely want to fix it. Otherwise, please update the documentation accordingly.

If you have difficult reproducing the problem or need additional information about my environment, please let me know. Thanks!

@alexrashed
Copy link
Member

Hi @kerwinyoder!
This seems to be related to the recent upgrade of our dependency on bitnami's common chart (#93).
It seems like the last release of the commons chart broke the compatibility.
Particularly this PR seems to introduce the incompatibility: bitnami/charts#18154
The issue is already discussed in the PR and it currently has some traction (which makes me think that there might be a fix soon).
Is this blocking you currently? A simple workaround for now would be to upgrade to a newer version of Helm. I can verify that it works with the latest version of the helm CLI, but also that the issue is reproducible with 3.5.4.

@alexrashed alexrashed self-assigned this Sep 4, 2023
@alexrashed alexrashed added the type: bug Bug relating to a chart in this repo label Sep 4, 2023
@alexrashed
Copy link
Member

It seems like this was a bit under the radar. I created bitnami/charts#19011 to discuss this issue.
If this issue blocks you, we could also pin the bitnami/common version for now until this issue is resolved in the dependency.

@kerwinyoder
Copy link
Author

Hi @alexrashed

Thanks for your prompt responses! I would not classify this as a blocker. We have several workarounds, including the one you mentioned of upgrading Helm. I didn't realize this chart depends on Bitnami's commons chart. Thanks for tracking that down and creating the issue there. It looks like they have already started working it, so perhaps they will have a fix out soon. If not, we will use one of the workarounds. Thanks again!

@alexrashed
Copy link
Member

Hi @kerwinyoder!
This issue has been fixed in the bitnami/[email protected] (in bitnami/charts#19177).
I just upgraded the lock file (in f4526b4) and triggered a new release (0.6.4), so this issue should be resolved in the latest version.
Please let us know if you are still experiencing any issues. Thanks again for making us aware of this! 💯

@kerwinyoder
Copy link
Author

Hi @alexrashed

I tested 0.6.4 and it works. Thanks for the quick fix! 🏆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Bug relating to a chart in this repo
Projects
None yet
Development

No branches or pull requests

2 participants