Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally save to a text file instead of text source #6

Closed
Destroy666x opened this issue Aug 20, 2023 · 14 comments
Closed

Optionally save to a text file instead of text source #6

Destroy666x opened this issue Aug 20, 2023 · 14 comments
Labels
enhancement New feature or request

Comments

@Destroy666x
Copy link
Contributor

Would be great if last detected sentences were optionally sent to a chosen text file instead of a chosen text source.

Why? For much easier usage outside of OBS, e.g. with external integrations. Or even inside OBS for wider support, e.g. by plugins that can read from text files in their custom sources.

@royshil
Copy link
Collaborator

royshil commented Aug 23, 2023

wonderful idea - and not too difficult to implement

@royshil royshil added the enhancement New feature or request label Aug 23, 2023
@klasadoroty
Copy link

Hi,
This seems to be the most important addition, too.
Great work.

@royshil
Copy link
Collaborator

royshil commented Sep 6, 2023

@Destroy666x do you have a particular format in mind? like .srt or the like - or just output the current caption into a .txt file with only the current caption (i.e. it gets deleted and overwritten)

@Destroy666x
Copy link
Contributor Author

Destroy666x commented Sep 6, 2023

Basic .txt would be the most widely-supported and easiest to parse format. .srt is a good option as well, but more niche I'd say. Supporting both would be the best ofc, but if I was to choose one, then I'd go for .txt first for sure.

@royshil
Copy link
Collaborator

royshil commented Sep 8, 2023

implemented in #11

@royshil
Copy link
Collaborator

royshil commented Sep 8, 2023

@Destroy666x @klasadoroty can yall try this build plz https://github.com/royshil/obs-localvocal/actions/runs/6124248762#artifacts ?
see if the file output works out for you
it does for me on Windows

@Destroy666x
Copy link
Contributor Author

Destroy666x commented Sep 8, 2023

@royshil something feels off for now (Windows 10, OBS 29.1.3):

  • OBS lagged and crashed when I copied the filter from once source to another, worked another time
  • the file reloads with new content but after initially saving some phrases, now it saves nothing (kind of similar issue as in your request plugin of it stopping working after some time)

@royshil
Copy link
Collaborator

royshil commented Sep 8, 2023

@Destroy666x
do you have any logs or crash logs from those sessions?
i personally haven't tries filter copying, so i can try that and see if i replicate the crash

the "stops after a while" situation i can't replicate on my machine, it's pretty stable for me
so i'm suspecting another confounding factor
are you able to try this out in a fresh scene? or potentially fresh portable OBS?

@Destroy666x
Copy link
Contributor Author

Destroy666x commented Sep 8, 2023

Crash:
Crash 2023-09-08 20-04-47.txt

2nd part may be related to performance and just huge delays as I noticed that some phrases were appearing late. I'll test more after restart since my CPU lagged a bit this session. Tooltips/description of the fields would also help.

Would you say the default setting is optimal in terms of CPU usage? This also reported lags: #9

@royshil
Copy link
Collaborator

royshil commented Sep 11, 2023

@Destroy666x i think i fixed the problem, can you try https://github.com/royshil/obs-localvocal/actions/runs/6142702487 ? 🙏

@royshil
Copy link
Collaborator

royshil commented Sep 12, 2023

@Destroy666x did yo get a chance to check the fix for the file output?

@Destroy666x
Copy link
Contributor Author

Oh, there was a separate fix, I thought it'd be the link to the optimization. I'll check real quick now.

@Destroy666x
Copy link
Contributor Author

Copying the filter works consistently now, I think.

@royshil
Copy link
Collaborator

royshil commented Sep 12, 2023

implemented in #11 . closing

@royshil royshil closed this as completed Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants