Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitles #45

Closed
L3gion132 opened this issue Oct 26, 2023 · 7 comments
Closed

Subtitles #45

L3gion132 opened this issue Oct 26, 2023 · 7 comments
Milestone

Comments

@L3gion132
Copy link

Subtitles show [Skip] when not generating as well as the time for the subtitles remaining on screen is to short for people to read them

@L3gion132
Copy link
Author

1
2
3

@royshil
Copy link
Collaborator

royshil commented Oct 26, 2023

I can make some changes to address this
Like a minimum display time for captions as well as not showing "skip"

@royshil
Copy link
Collaborator

royshil commented Oct 29, 2023

implemented in #46

@L3gion132 can you please test the build artifacts? 🙏

@L3gion132
Copy link
Author

implemented in #46

@L3gion132 can you please test the build artifacts? 🙏

Hi How do I go about doing that?

@royshil
Copy link
Collaborator

royshil commented Oct 29, 2023

@L3gion132 every pull request builds artifacts
https://github.com/obs-ai/obs-localvocal/actions/runs/6681222435#artifacts

download the ones you need, you'll find the plugin inside the .zip

@L3gion132
Copy link
Author

Thanks Testing currently and it works wonders no issues with the time on screen and the [Skip] is gone thank you for the fantastic work

@royshil royshil added this to the 0.0.6 milestone Nov 1, 2023
@royshil
Copy link
Collaborator

royshil commented Nov 4, 2023

resolved

@royshil royshil closed this as completed Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants