Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new dropped_iterations metric #1529

Merged
merged 5 commits into from
Jul 3, 2020
Merged

Add a new dropped_iterations metric #1529

merged 5 commits into from
Jul 3, 2020

Conversation

na--
Copy link
Member

@na-- na-- commented Jul 2, 2020 •
edited
Loading

No description provided.

@na-- na-- requested review from mstoykov and imiric July 2, 2020 12:39
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2020 •
edited
Loading

Codecov Report

Merging #1529 into new-schedulers will increase coverage by 0.02%.
The diff coverage is 92.59%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           new-schedulers    #1529      +/-   ##
==================================================
+ Coverage           77.29%   77.32%   +0.02%     
==================================================
  Files                 162      162              
  Lines               13095    13127      +32     
==================================================
+ Hits                10122    10150      +28     
- Misses               2455     2457       +2     
- Partials              518      520       +2
Impacted Files Coverage Δ
lib/executor/base_executor.go 83.33% <42.85%> (-16.67%) ⬇️
js/runner.go 83.10% <100.00%> (+0.11%) ⬆️
lib/executor/constant_arrival_rate.go 96.75% <100.00%> (+0.09%) ⬆️
lib/executor/constant_vus.go 96.73% <100.00%> (ø)
lib/executor/per_vu_iterations.go 97.27% <100.00%> (+0.12%) ⬆️
lib/executor/ramping_arrival_rate.go 96.72% <100.00%> (+0.07%) ⬆️
lib/executor/ramping_vus.go 94.23% <100.00%> (ø)
lib/executor/shared_iterations.go 97.69% <100.00%> (+0.11%) ⬆️
lib/testutils/minirunner/minirunner.go 78.57% <100.00%> (-2.92%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07dea12...966510c. Read the comment docs.

@na-- na-- mentioned this pull request Jul 3, 2020
Merged
@na-- na-- force-pushed the dropped-iterations branch from 6034436 to 2ad16fa Compare July 3, 2020 06:25
@na-- na-- changed the title [WIP] Add a new dropped_iterations metric Add a new dropped_iterations metric Jul 3, 2020
@na-- na-- added this to the v0.27.0 milestone Jul 3, 2020
imiric
imiric approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of questions.

lib/executor/per_vu_iterations.go Show resolved Hide resolved
lib/executor/shared_iterations.go Show resolved Hide resolved
Base automatically changed from fixRampingArrivalRateUnplannedVUs to new-schedulers July 3, 2020 12:20
@na-- na-- force-pushed the dropped-iterations branch from e2bbb8d to 966510c Compare July 3, 2020 13:17
@na-- na-- merged commit 41a4f73 into new-schedulers Jul 3, 2020
@na-- na-- deleted the dropped-iterations branch July 3, 2020 13:48
@na-- na-- mentioned this pull request Jul 8, 2020
Closed
@na-- na-- mentioned this pull request Aug 13, 2020
Open
mstoykov pushed a commit that referenced this pull request Dec 13, 2024
@andrewslotin
Migrate to k6 roadmap (#1529)
7a8ee0c 
* Refer to the public k6 roadmap in the README

* Delete the outdated roadmap

* Update release badge URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imiric imiric imiric approved these changes

@mstoykov mstoykov mstoykov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.27.0
Development

Successfully merging this pull request may close these issues.
4 participants
@na-- @codecov-commenter @mstoykov @imiric