Don't leak goroutines everywhere in the ws code #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous to this past running k6 compiled with the race detector and ws code will most definetely leak enough goroutines in 10 seconds that it will stop because of the 8k limit ... After this it seems to not leak anymore :confetti:
Codecov Report
@@ Coverage Diff @@
## new-schedulers #1513 +/- ##
==================================================
- Coverage 76.71% 76.67% -0.04%
==================================================
Files 163 163
Lines 13030 13044 +14
==================================================
+ Hits 9996 10002 +6
- Misses 2521 2529 +8
Partials 513 513
Continue to review full report at Codecov.
|
na--
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this, running k6 compiled with the race detector and ws
code will most definitely leak enough goroutines in 10 seconds that it
will stop because of the 8k limit ...
After this it seems to not leak anymore :confetti: I tested with 2k VUs
which use around 7.5k goroutines and it seemed to move withing 200/300
goroutines over a period of 5minutes without ever actually looking like
some goroutines leaked