Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --sloppy option #75

Merged
merged 2 commits into from
May 21, 2017
Merged

Added --sloppy option #75

merged 2 commits into from
May 21, 2017

Conversation

shilman
Copy link
Contributor

@shilman shilman commented May 20, 2017

The --sloppy option allows you to create a CHANGELOG without checking your local state. This is useful for the first-time user experience when, for example, you might be editing your CHANGELOG in a non-master branch for feedback (e.g. storybookjs/storybook#1047)

NOTE: I couldn't get the code coverage to work properly. The test runner says I am at 100% coverage, but the coverage test still fails. Any help would be much appreciated here!

@lo1tuma
Copy link
Owner

lo1tuma commented May 20, 2017

Thanks for this Pull Request @shilman. This looks definitely like a useful addition.

Regarding the coverage, on travis-ci everything seems to work correctly, I’ve also checked out your branch locally and it works fine for me as well.
Do you have the correct dependencies installed? Because this project uses a forked version of istanbul-api which fixes this bug.
However this reminds me that I should change the setup to use nyc instead which is not affected by the bug mentioned above. I hope I find some time for this in the next days.

@shilman
Copy link
Contributor Author

shilman commented May 20, 2017

@lo1tuma OK i didn't have the right version of istanbul installed. Somehow yarn doesn't like that version format, but when I installed with npm it worked fine. So I think this is safe to merge.

@shilman
Copy link
Contributor Author

shilman commented May 20, 2017

(though happy to make changes if you see anything you don't like! 😄 )

@shilman
Copy link
Contributor Author

shilman commented May 20, 2017

BTW, inspired/super-impressed with your 100% test coverage 🙇

@lo1tuma
Copy link
Owner

lo1tuma commented May 21, 2017

Thanks a lot 👍 .

@lo1tuma lo1tuma merged commit 084c0a3 into lo1tuma:master May 21, 2017
@shilman shilman deleted the sloppy-option branch May 23, 2017 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants