Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add random image after seller creates order #608

Open
grunch opened this issue Nov 26, 2024 · 5 comments · May be fixed by #619
Open

Add random image after seller creates order #608

grunch opened this issue Nov 26, 2024 · 5 comments · May be fixed by #619
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@grunch
Copy link
Member

grunch commented Nov 26, 2024

A new way to scam sellers is, having a telegram username similar to @lnp2pBot and send a lightning invoice to the seller, some sellers paid and they just lose the money because those are invoices from the scammer.

As this way to scam only not experienced users, we need a way of make those users to be aware of irregular behavior, so after read an idea from @Catrya of sending random numbers to sellers after the order creation I came with the idea of seding random images instead, this is easier to remember, and it is much more striking.

So the main idea is after a seller creates an order we should send the same message we are sending now and add a random image with small paragraph explaining something like "you will see this same image at the time of pay the invoice", so we should add that same image in the center of the QR code to be pay after a buyer take the order.

@grunch grunch added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Nov 26, 2024
@Catrya Catrya moved this to 👨‍💻 Looking for dev in Developer Rewards ⚡👩‍💻 Dec 16, 2024
@ndungudedan
Copy link

Hi

Can I be assigned this issue?

Thank you.

@Catrya
Copy link
Member

Catrya commented Dec 19, 2024

Hi, @ndungudedan I already assigned it to you.

I'll give you a bit more context: the images should not be too detailed and should feature bright colors that stand out. This is because some users have automatic image downloads disabled in Telegram. Even if they don't download the image, they can still prevent scams. When they see the blurred image, they can compare the colors with those in the center of the QR code, making it easy to identify whether they match or not.
If you need any further clarification, just let me know.

@Catrya Catrya moved this from 👨‍💻 Looking for dev to 📝 In Progress in Developer Rewards ⚡👩‍💻 Dec 19, 2024
@grunch
Copy link
Member Author

grunch commented Dec 19, 2024

I think for images we show something something simple and easily identifiable even if it is blurry, for example

blue bird
yellow plane
red lion
pink house

and go on...

@ndungudedan
Copy link

Hi @Catrya

Just to confirm I understand the task, here are some quick clarifications I need.

Scenario 1:

When you create a sell order, you get the message below. I am going to add the image to this response with the following explanatory text: "You will see this same image at the time of paying the invoice." Afterwards, when the order is matched, they will receive an invoice with a similar image.

📝 Your offer has been published in the [@p2pbot_dedan](https://t.me/p2pbot_dedan) channel

You have to wait until another user picks your order, it will be available for 23 hours in the channel

You can cancel this order before another user picks it up by executing the command 👇

Scenario 2:
When accepting an order from the channel, you receive the message below. Similarly, I will add the image to this response and inform the user to expect the same image when paying the invoice.

🤖 Press Continue to take the offer, if you press Cancel, you will be released from the order and it will be republished. You have 10 minutes before this order expires. 👇

Also thinking of adding a reminder on this response Please pay this invoice of 5,117 sats for $ 5 to start the operation.which accompanies the invoice. Something like: "Please confirm the image on the QR is similar to the previous image."

@Catrya
Copy link
Member

Catrya commented Dec 20, 2024

Hi @ndungudedan you understood correctly. Good job! Go ahead. If you have any other questions just ask

@ndungudedan ndungudedan linked a pull request Dec 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: 📝 In Progress
Development

Successfully merging a pull request may close this issue.

3 participants