Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handoff LLVM and PyTorch updates #1486

Closed
ashay opened this issue Oct 12, 2022 · 4 comments
Closed

Handoff LLVM and PyTorch updates #1486

ashay opened this issue Oct 12, 2022 · 4 comments

Comments

@ashay
Copy link
Collaborator

ashay commented Oct 12, 2022

Due to a change in my job responsibilities, I am unable to continue to contribute to Torch-MLIR, so this issue records tasks that I had been previously working on and their new ownership.

  1. Green commits: I will continue to post LLVM green commits every week, update MHLO to said LLVM commit, and post the MHLO green commit to the Issue LLVM green commit tracking for coordination experiment #1178.

  2. LLVM updates: We need a new owner for updating the LLVM tag in Torch-MLIR based on the green commit posted in the issue referenced above.

  3. PyTorch updates: These are automated through the RollPyTorch Github Action, with the exception that the Github Action itself is not scheduled. However, we can improve the RollPyTorch action's robustness by: (a) setting up a Github bot that creates a daily PR for updating the PyTorch version, shape library, and Torch ODS and (b) setting up another Github bot that approves and merges the PR if builds succeed. Creating such PRs is better than our current approach of directly committing the updates to the main branch since the PR would (a) run the full gamut of tests for PRs, (b) warm up all caches, and (c) allow unrelated concurrent merges from other PRs while the RollPyTorch action is in progress. We get around the last part by running the RollPyTorch action early in the day when there is a low likelihood of other PRs being merged.

  4. [Non-Recurring Task] Build cache improvements: The PyTorch source builds currently take a long time to run because PyTorch uses pre-compiled headers, which aren't directly compatible with ccache. Issue excessive cache invalidation in ccache #1323 tracks some findings and possible next steps to make the build run faster.

cc: @silvasean

@silvasean
Copy link
Contributor

@powderluv @ZihengJiang @tanyokwok @ramiro050 -- do you folks have any bandwidth on your teams for helping with the LLVM updates? I think we can make a rotation of various engineers that do the update after Ashay tags the green commit hashes.

@powderluv
Copy link
Collaborator

We are happy take over the PyTorch updates if anyone else wants to take over the LLVM update. We are happy to help rotate on the LLVM fixes too.
Overall having a good cadence on LLVM and PyTorch updates is crucial to the continued success of the project so we will help in anyway if there are gaps.

@tanyokwok
Copy link
Collaborator

tanyokwok commented Oct 13, 2022

@ashay Thanks for the contributions to Torch-MLIR you have made. We are glad to help with the rotation of LLVM and PyTorch updates! cc @silvasean

@ashay
Copy link
Collaborator Author

ashay commented Oct 14, 2022

Closing because we seem to have good coverage for all mentioned tasks. Thanks folks!

@ashay ashay closed this as completed Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants