Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport libc++ fix to formatter #87800

Closed
androm3da opened this issue Apr 5, 2024 · 2 comments
Closed

backport libc++ fix to formatter #87800

androm3da opened this issue Apr 5, 2024 · 2 comments
Labels
format C++20 std::format or std::print, and anything related to them libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. release:backport
Milestone
LLVM 18.X Release

Comments

@androm3da
Copy link
Member

We should backport this fix to formatter_floating_point because it causes compilation errors on targets where int32_t is not compatible with int.

/cherry-pick e1830f5
@androm3da androm3da added this to the LLVM 18.X Release milestone Apr 5, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Apr 5, 2024
@github-actions github-actions bot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Apr 5, 2024
@androm3da androm3da mentioned this issue Apr 5, 2024
Merged
@mordante
Copy link
Member

mordante commented Apr 5, 2024

Thanks for the backport request!
FYI you could have set the milestone in the PR and request the backporting there. (This works too.)

@EugeneZelenko EugeneZelenko added release:backport format C++20 std::format or std::print, and anything related to them labels Apr 5, 2024
@llvmbot llvmbot closed this as completed Apr 5, 2024
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in LLVM Release Status Apr 5, 2024
@llvmbot
Copy link
Member

llvmbot commented Apr 5, 2024

/pull-request #87801

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
format C++20 std::format or std::print, and anything related to them libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. release:backport
Projects
LLVM Release Status
Status: Done
Milestone
LLVM 18.X Release
Development

No branches or pull requests
4 participants
@mordante @androm3da @EugeneZelenko @llvmbot