Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wasm] weak symbol issue #60829

Closed
yamt opened this issue Feb 17, 2023 · 3 comments
Closed

[Wasm] weak symbol issue #60829

yamt opened this issue Feb 17, 2023 · 3 comments
Assignees
@sbc100
Labels
lld:wasm

Comments

@yamt
Copy link
Contributor

yamt commented Feb 17, 2023

when you have weak and non-weak references to a non exiting symbol, linker seems to treat them as they were all weak references.
a small demo code: https://github.com/yamt/garbage/tree/master/c/weak
@yamt yamt mentioned this issue Feb 17, 2023
Merged
@llvmbot
Copy link
Member

llvmbot commented Feb 17, 2023

@llvm/issue-subscribers-backend-webassembly

@sbc100 sbc100 self-assigned this Feb 17, 2023
@sbc100
Copy link
Collaborator

sbc100 commented Feb 24, 2023

Fix in flight: https://reviews.llvm.org/D144747

@sbc100 sbc100 closed this as completed in d65ed8c Feb 27, 2023
@llvmbot
Copy link
Member

llvmbot commented Feb 27, 2023

@llvm/issue-subscribers-lld-wasm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbc100 sbc100

Labels
lld:wasm
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sbc100 @yamt @EugeneZelenko @llvmbot