Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[InstructionSimplify] AS casts can cause bit-width of constants to be incompatible #53860

Closed
jdoerfert opened this issue Feb 15, 2022 · 8 comments
Closed

[InstructionSimplify] AS casts can cause bit-width of constants to be incompatible #53860

jdoerfert opened this issue Feb 15, 2022 · 8 comments
Assignees
@nikic @jdoerfert
Labels
llvm:optimizations release:backport release:merged release:reviewed
Milestone
LLVM 14.0.0 Release

Comments

@jdoerfert
Copy link
Member

If we have AS casts mixed with inbounds and non-inbounds GEPs (and probably also in the absence of GEPs) we can run into bit-width issues.

This is similar to #53559 but this time in InstructionSimplify.cpp.

An earlier attempt to fix this (https://reviews.llvm.org/D64768) did not address all potential issues but only a special case.

Proposed fix: https://reviews.llvm.org/D119740
@jdoerfert jdoerfert added this to the LLVM 14.0.0 Release milestone Feb 15, 2022
@jdoerfert jdoerfert self-assigned this Feb 15, 2022
@jdoerfert
Copy link
Member Author

FYI, @nikic @arsenm

@jdoerfert
Copy link
Member Author

Effectively fixed by f35af77, see https://reviews.llvm.org/D119740#3325545.

\cherry-pick f35af77

@tstellar
Copy link
Collaborator

/cherry-pick f35af77

@llvmbot
Copy link
Member

llvmbot commented Feb 16, 2022

/branch llvmbot/llvm-project/issue53860

@llvmbot llvmbot mentioned this issue Feb 16, 2022
Merged
@llvmbot
Copy link
Member

llvmbot commented Feb 16, 2022

/pull-request llvmbot#72

@tstellar
Copy link
Collaborator

@nikic What do you think about backporting this? f35af77

@nikic
Copy link
Contributor

nikic commented Feb 21, 2022

@tstellar Should be fine to backport.

@tstellar
Copy link
Collaborator

Merged: 08ad9ae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikic nikic

@jdoerfert jdoerfert

Labels
llvm:optimizations release:backport release:merged release:reviewed
Projects
None yet
Milestone
LLVM 14.0.0 Release
Development

No branches or pull requests
5 participants
@tstellar @nikic @jdoerfert @EugeneZelenko @llvmbot