Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport patches for GAS optionality in OpenCL 3.0 to 14.0.0 #53822

Closed
AnastasiaStulova opened this issue Feb 14, 2022 · 5 comments
Closed

Backport patches for GAS optionality in OpenCL 3.0 to 14.0.0 #53822

AnastasiaStulova opened this issue Feb 14, 2022 · 5 comments
Labels
OpenCL release:backport release:merged release:reviewed
Milestone
LLVM 14.0.0 Release

Comments

@AnastasiaStulova
Copy link
Contributor

These are the patches for generic address space optionality (includes minor refactoring + fixes) committed by @svenvh:

e0e6f3a [OpenCL] Test -fdeclare-opencl-builtins with CL3 and CLC++2021
d97a4df [OpenCL] Move most _explicit atomics into multiclass; NFC
31fa3a4 [OpenCL] Move OpenCL 2.0 atomics into multiclass; NFC
fe69058 [OpenCL] Fix atomic_fetch_add/sub with half type
8d37043 [OpenCL] Refactor cl_ext_float_atomics declarations; NFC
50f8abb [OpenCL] Add OpenCL 3.0 atomics to -fdeclare-opencl-builtins

These are patches to complete OpenCL 3.0 and they are not affecting widespread functionality as they are OpenCL parsing specific so they should ideally not impact the release cycle at this point although it would be good to cherry-pick them sooner rather than later.
@AnastasiaStulova AnastasiaStulova added this to the LLVM 14.0.0 Release milestone Feb 14, 2022
@llvmbot
Copy link
Member

llvmbot commented Feb 14, 2022

@llvm/issue-subscribers-opencl

@AnastasiaStulova
Copy link
Contributor Author

/cherry-pick e0e6f3a d97a4df 31fa3a4 fe69058 8d37043 50f8abb

@llvmbot
Copy link
Member

llvmbot commented Feb 14, 2022

/branch llvmbot/llvm-project/issue53822

@llvmbot llvmbot mentioned this issue Feb 14, 2022
Merged
@llvmbot
Copy link
Member

llvmbot commented Feb 14, 2022

/pull-request llvmbot#55

@AnastasiaStulova AnastasiaStulova mentioned this issue Feb 14, 2022
Closed
@tstellar
Copy link
Collaborator

tstellar commented Feb 14, 2022 •
edited
Loading

Merged: 8b3ba44 174dffb 865a18c 8426097 f4c48b2 fa24d7e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OpenCL release:backport release:merged release:reviewed
Projects
None yet
Milestone
LLVM 14.0.0 Release
Development

No branches or pull requests
3 participants
@tstellar @AnastasiaStulova @llvmbot