-
Notifications
You must be signed in to change notification settings - Fork 12.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[AMDGPU][True16] fix a bug in codeGen causing e64 with wrong vgpr typ…
…e to shrink (#102942) This bug is introduced in #102198 The previous path change to use realTrue16 flag, however, we have some t16 instructions that are implemented with fake16, and has Lo128 registers types. Thus we should still using hasTrue16Bit flag for shrinking check --------- Co-authored-by: guochen2 <[email protected]>
- Loading branch information
1 parent
825dbbb
commit 6b7afaa
Showing
2 changed files
with
29 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py | ||
# RUN: llc -mtriple=amdgcn -mcpu=gfx1100 -run-pass=si-shrink-instructions -verify-machineinstrs -o - %s | FileCheck -check-prefix=GFX1100 %s | ||
|
||
--- | ||
name: 16bit_lo128_shrink | ||
tracksRegLiveness: true | ||
body: | | ||
bb.0: | ||
liveins: $vgpr127 | ||
; GFX1100-LABEL: name: 16bit_lo128_shrink | ||
; GFX1100: liveins: $vgpr127 | ||
; GFX1100-NEXT: {{ $}} | ||
; GFX1100-NEXT: V_CMP_EQ_U16_t16_e32 0, $vgpr127, implicit-def $vcc, implicit $exec, implicit $exec | ||
$vcc_lo = V_CMP_EQ_U16_t16_e64 0, $vgpr127, implicit-def $vcc, implicit $exec | ||
... | ||
|
||
--- | ||
name: 16bit_lo128_no_shrink | ||
tracksRegLiveness: true | ||
body: | | ||
bb.0: | ||
liveins: $vgpr128 | ||
; GFX1100-LABEL: name: 16bit_lo128_no_shrink | ||
; GFX1100: liveins: $vgpr128 | ||
; GFX1100-NEXT: {{ $}} | ||
; GFX1100-NEXT: $vcc_lo = V_CMP_EQ_U16_t16_e64 0, $vgpr128, implicit-def $vcc_lo, implicit $exec | ||
$vcc_lo = V_CMP_EQ_U16_t16_e64 0, $vgpr128, implicit-def $vcc, implicit $exec | ||
... |