Distinct public visibility in class methods and class properties

[llaville]

As discussed in report llaville/php-compatinfo#129 and of course in PHP-Parser itself !

[llaville]

Will implement Graham and Nikita 's solution suggested in nikic/PHP-Parser#136

[llaville]

First attempt that run fine, but without the reflect cache plugin. Have a look on branch TokenOffsets, commit 4daccd5

[llaville]

With commit the solution run both with and without the cachePlugin.

[llaville]

Following your latest comment, we will discuss the situation here.

To understand why I've adopted the token_get_all, get the current php-reflect repository from master branch of event the TokenOffsets branch.

See summary of merge bae9de8

And remove the lines

    $tokens = @token_get_all(
        file_get_contents($file->getPathname())
    );

in Reflect.php file

Run the simple analysis test on a file like https://github.com/llaville/php-compat-info/blob/master/tests/_files/gh129.php, with a cachePlugin setted

php phpreflect.phar analyser:run .

You will get the summary report on first run

Do it again, and see what PHP error you will get. I'm sure you'll understand the situation.

Rather than follow Nikita suggestion (put the tokens in cache with ast) I read it in live, because if source code changed, the cache will be invalidate and phpreflect will run a new standard parse.